Giters

tomzx / php-semver-checker

Compares two source sets and determines the appropriate semantic versioning to apply.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add tests for fully qualified classes/interfaces/traits/functions names

tomzx opened this issue · comments

commented

As of now, we use \PhpParser\NodeVisitor\NameResolver to resolve the full name (namespace + name) of classes/interfaces/traits/functions names.

While moving from my old branch of php-parser to the latest one (1.3.0), the NameResolver seems to have changed for functions and thus the name of the outputted functions did not match the previous output.

Adding some tests should alert us if any dependencies ends up changing enough for the output to change/break.

commented

Should be covered by 002f3e1.