map service
tomwayson opened this issue · comments
It's a bit overkill given the limited mapping functionality of this repo (so far), but it would be good to show the pattern of using a service to encapsulate all mapping functionality.
After creating that, should wrap up #5 by passing the mock map service (instead of a mock route) in the map component test. Also demonstrate how to test the logic in the map service - honestly may need to add some more logic to test first.
I'm not sure this makes sense any more now that we are using angular2-esri4-components. If a map service still makes sense anywhere, it's probably in that repository.
Closing for now, but can re-open if there's a need.