Message routing fail if using Skype as Agent

Question

Message routing fail if using Skype as Agent

dzeping96 opened this issue 7 years ago · comments

Sorry for my English first..

Skype: Customer Agent
Bot Emulator: User

I found out that when I am using Skype as Agent, it unable to reply message to User, but I can receive message from User. If I am using other Channel other than Skype as Agent, it working fine. And also, I tried to use Bot Emulator as Agent and Skype as User, it is working fine too. I found out the problem is because of this part messageRouterResult = await messageRouterManager.HandleActivityAsync(activity, false);. If we using other Channel as Agent, it will reply OK as result, but if we using Skype as Agent, it will reply NoActionTaken as result. I just download this sample and tested without anything change, hope you can help me to solve this issues. Thanks a lot!

Here is some screenshot:-
Agent on Skype

User on Emulator

Tomi Paananen · Answer 1 · Sun Nov 19 2017 17:54:25 GMT+0800 (China Standard Time)

Thank you for reporting this and for the precise issue description! This is an obvious bug that needs to be fixed.

Jamie D · Answer 2 · Sun Nov 19 2017 18:23:17 GMT+0800 (China Standard Time)

Thought I'd fixed this a while back? a19b34d Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Tomi Paananen <notifications@github.com> Sent: Sunday, November 19, 2017 9:54:25 AM To: tompaana/intermediator-bot-sample Cc: Subscribed Subject: Re: [tompaana/intermediator-bot-sample] Message routing fail if using Skype as Agent (#24) Thank you for reporting this and for the precise issue description! This is an obvious bug that needs to be fixed. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftompaana%2Fintermediator-bot-sample%2Fissues%2F24%23issuecomment-345504699&data=02%7C01%7Cdaltskin%40hotmail.com%7Ca7cebc26333348da636d08d52f3384ef%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636466820670771585&sdata=%2BmvxcnkXt48tupG0ibBXo5wcpx4hVtkZ%2F93%2Fs6wgx%2B8%3D&reserved=0>, or mute the thread<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABmb7oxdjy0juae8v6sSR9g2c-oSq0Qoks5s3_rRgaJpZM4Qi20Y&data=02%7C01%7Cdaltskin%40hotmail.com%7Ca7cebc26333348da636d08d52f3384ef%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636466820670927862&sdata=Q6lBZOJTe9z8ifyPRBY0cJi%2Bsemt616Ge5SZ8WLss6I%3D&reserved=0>.

Tomi Paananen · Answer 3 · Sun Nov 19 2017 18:27:15 GMT+0800 (China Standard Time)

@daltskin Unfortunately that fix broke the functionality for many other channels. I didn't just revert the changes, but added a special case in the code for Skype, but must've missed to test the case where Skype is the agent channel.

Jamie D · Answer 4 · Sun Nov 19 2017 19:13:10 GMT+0800 (China Standard Time)

Hmm. Does highlight the challenge around channel testing. Labouriois without unit tests! Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Tomi Paananen <notifications@github.com> Sent: Sunday, November 19, 2017 10:27:15 AM To: tompaana/intermediator-bot-sample Cc: Jamie D; Mention Subject: Re: [tompaana/intermediator-bot-sample] Message routing fail if using Skype as Agent (#24) @daltskin<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdaltskin&data=02%7C01%7Cdaltskin%40hotmail.com%7Ca9ed1d625fc24b2ee92b08d52f381c2a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636466840384281452&sdata=QECdHZEf0%2Fs8G9MFx91C8qmHPDSp5ntDfZQJyldjvao%3D&reserved=0> Unfortunately that fix broke the functionality for many other channels. I didn't just revert the changes, but added a special case in the code for Skype, but must've missed to test the case where Skype is the agent channel. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftompaana%2Fintermediator-bot-sample%2Fissues%2F24%23issuecomment-345506447&data=02%7C01%7Cdaltskin%40hotmail.com%7Ca9ed1d625fc24b2ee92b08d52f381c2a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636466840384281452&sdata=3F2mXwp%2FBKjfj4ny0t0D8kQw9hO9avK4s%2F7LIsMLmVQ%3D&reserved=0>, or mute the thread<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABmb7hrXGHn0AIIp34RErW9F73EsGDnFks5s4AKDgaJpZM4Qi20Y&data=02%7C01%7Cdaltskin%40hotmail.com%7Ca9ed1d625fc24b2ee92b08d52f381c2a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636466840384281452&sdata=7gbAvhgT%2FBp3LXVV%2BavZSmn2DaYe0YG48O6MyMcMqMk%3D&reserved=0>.

Tomi Paananen · Answer 5 · Sun Nov 19 2017 19:29:20 GMT+0800 (China Standard Time)

@daltskin Indeed.

dzeping96 · Answer 6 · Mon Nov 20 2017 09:50:46 GMT+0800 (China Standard Time)

@tompaana
No problem. I will wait for your fix. Thank you so much!

dzeping96 · Answer 7 · Tue Nov 21 2017 15:14:15 GMT+0800 (China Standard Time)

Hi @tompaana,

FYI, I found out another problem, which after I publish the sample to Azure App Service plan with Release configuration, the Skype channel won't reply anything at all, it still working fine on any other channel. Is this related with the bug I mentioned in this topic? Thanks!

Jamie D · Answer 8 · Tue Nov 21 2017 16:05:19 GMT+0800 (China Standard Time)

There are some conditional #debug statements, could be related... Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: dzeping96 <notifications@github.com> Sent: Tuesday, November 21, 2017 7:14:15 AM To: tompaana/intermediator-bot-sample Cc: Jamie D; Mention Subject: Re: [tompaana/intermediator-bot-sample] Message routing fail if using Skype as Agent (#24) Hi @tompaana<https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftompaana&data=02%7C01%7Cdaltskin%40hotmail.com%7Ce1807667f1db41bf173b08d530af7a27%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636468452574309581&sdata=Qz%2B3DhRrp63CVf9vvN15xs72qRLk8O6ZJSVUwy5tWvA%3D&reserved=0>, FYI, I found out another problem, which after I publish the sample to Azure App Service plan with Release configuration, the Skype channel won't reply anything at all, it still working fine on any other channel. Is this related with the bug I mentioned in this topic? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftompaana%2Fintermediator-bot-sample%2Fissues%2F24%23issuecomment-345937440&data=02%7C01%7Cdaltskin%40hotmail.com%7Ce1807667f1db41bf173b08d530af7a27%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636468452574309581&sdata=B%2Fdi%2BvaxCSbPrcU7CC8EafbeYf9cqnrOR0hC6HSEi1w%3D&reserved=0>, or mute the thread<https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABmb7mk047Aenemj6_rX2w7Wpqupnm45ks5s4nhHgaJpZM4Qi20Y&data=02%7C01%7Cdaltskin%40hotmail.com%7Ce1807667f1db41bf173b08d530af7a27%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636468452574309581&sdata=OegpXLW5%2BXIR3NU6p0VhT0zvLuF2hg45h7wM50oeoGw%3D&reserved=0>.

dzeping96 · Answer 9 · Wed Nov 22 2017 10:01:37 GMT+0800 (China Standard Time)

Hi @daltskin,

Thanks for your assisting, I just found out that Skype require some time to let the Channel online after switching endpoint. Thanks!

Tomi Paananen · Answer 10 · Thu Jan 25 2018 23:54:18 GMT+0800 (China Standard Time)

Fixed in commit 49c7f08