Bug in Dockerfile

[Yukha Dharmeswara]

Issues

1. By default, local-reverse-geocoder uses cities500 instead of cities1000. But, in Dockerfile we downloaded cities1000 instead.
   

   local-reverse-geocoder/app.js

   Line 62 in 8e6a1b8

    citiesFileOverride: 'cities500', 

2. Invalid cities directory name, it should be more specific like cities1000/ or cities500/, not only cities/
   

   local-reverse-geocoder/Dockerfile

   Line 21 in 8e6a1b8

    curl -L -o cities/cities1000.zip http://download.geonames.org/export/dump/cities1000.zip && \ 

Proof #1

There are cities/ and cities500/ directories in geonames_dump/ directory

/app# ls geonames_dump
admin1_codes  admin2_codes  all_countries  alternate_names  cities  cities500

Proof #2

Debug Log shows local-reverse-geocoder redownload cities files

/app# node app.js
Local reverse geocoder listening on port 3000
Initializing Geocoder…
(This may take a long time and will download ~2.29GB worth of data by default.)
  local-reverse-geocoder Using cities500 as override of cities database +0ms
  local-reverse-geocoder Initializing local reverse geocoder using dump directory: /app/geonames_dump +0ms
  local-reverse-geocoder Getting GeoNames cities500 data from https://download.geonames.org/export/dump/cities500.zip (this may take a while) +1ms
  local-reverse-geocoder Using cached GeoNames admin 1 codes data from /app/geonames_dump/admin1_codes/admin1CodesASCII.txt +2ms
  local-reverse-geocoder Using cached GeoNames admin 2 codes data from /app/geonames_dump/admin2_codes/admin2Codes.txt +1ms
  local-reverse-geocoder Using cached GeoNames all countries data from /app/geonames_dump/all_countries/allCountries.txt +0ms
  local-reverse-geocoder Started parsing all countries.txt (this  may take a while) +1ms
  local-reverse-geocoder Using cached GeoNames alternate names data from /app/geonames_dump/alternate_names/alternateNames.txt +0ms
  local-reverse-geocoder Parsing progress all countries 0 +10ms
  local-reverse-geocoder Parsing progress all countries 100000 +776ms
  local-reverse-geocoder Parsing progress all countries 200000 +474ms
  local-reverse-geocoder Parsing progress all countries 300000 +515ms
  local-reverse-geocoder Unzipping GeoNames cities500 data - found File cities500.txt +345ms
  local-reverse-geocoder Parsing progress all countries 400000 +192ms
  local-reverse-geocoder Parsing progress all countries 500000 +505ms
  local-reverse-geocoder Parsing progress all countries 600000 +642ms
  local-reverse-geocoder Parsing progress all countries 700000 +1s
  local-reverse-geocoder Parsing progress all countries 800000 +742ms
  local-reverse-geocoder Parsing progress all countries 900000 +570ms
  local-reverse-geocoder Parsing progress all countries 1000000 +479ms
  local-reverse-geocoder Parsing progress all countries 1100000 +716ms
  local-reverse-geocoder Parsing progress all countries 1200000 +385ms
  local-reverse-geocoder Parsing progress all countries 1300000 +434ms
  local-reverse-geocoder Parsing progress all countries 1400000 +686ms
  local-reverse-geocoder Parsing progress all countries 1500000 +452ms
  local-reverse-geocoder Parsing progress all countries 1600000 +469ms
  local-reverse-geocoder Parsing progress all countries 1700000 +792ms
  local-reverse-geocoder Parsing progress all countries 1800000 +493ms
  local-reverse-geocoder Parsing progress all countries 1900000 +851ms
  local-reverse-geocoder Parsing progress all countries 2000000 +471ms
  local-reverse-geocoder Parsing progress all countries 2100000 +466ms
  local-reverse-geocoder Parsing progress all countries 2200000 +924ms
  local-reverse-geocoder Parsing progress all countries 2300000 +530ms
  local-reverse-geocoder Parsing progress all countries 2400000 +735ms
  local-reverse-geocoder Parsing progress all countries 2500000 +660ms
  local-reverse-geocoder Parsing progress all countries 2600000 +458ms
  local-reverse-geocoder Parsing progress all countries 2700000 +947ms
  local-reverse-geocoder Parsing progress all countries 2800000 +544ms
  local-reverse-geocoder Parsing progress all countries 2900000 +472ms
  local-reverse-geocoder Parsing progress all countries 3000000 +619ms
  local-reverse-geocoder Parsing progress all countries 3100000 +1s
  local-reverse-geocoder Parsing progress all countries 3200000 +487ms
  local-reverse-geocoder Parsing progress all countries 3300000 +1s
  local-reverse-geocoder Parsing progress all countries 3400000 +634ms
  local-reverse-geocoder Parsing progress all countries 3500000 +1s
  local-reverse-geocoder Unzipped GeoNames cities500 data. +104ms
  local-reverse-geocoder - unzipped GeoNames cities500 data - cities500.txt +18ms
  local-reverse-geocoder Started parsing cities.txt (this  may take a while) +1ms

[Thomas Steiner]

Thanks for the Issue. Are you in a position to send a PR that fixes it?

[Yukha Dharmeswara]

Unfortunately couldn't, sorry mate.

[Thomas Steiner]

Fixed via 1d52b85 and released as v0.16.4.