`keepOldComments` is not used in the logic

Question

`keepOldComments` is not used in the logic

remal opened this issue 3 years ago · comments

Basically, it's a question.

As I can see, ViolationCommentsToGitHubApi.keepOldComments field is used only in withKeepOldComments and getKeepOldComments methods (setter & getter). Does it mean that this library doesn't remove commits that were left from the previous commits/CI run?

My goal is:

Run CI for a Pull Request
Send all violations to that PR
Commit is added / CI job is restarted
Remove previous violations sent to this PR
Send all violations from the new CI run to that PR

Is this goal achievable?

Tomas Bjerre · Answer 1 · Tue Jul 06 2021 03:07:29 GMT+0800 (China Standard Time)

Yes what you describe should work.

Logic is here:
https://github.com/tomasbjerre/violation-comments-lib/blob/12ecaef0a5c1ae8f81efbf199ec9db96db074b79/src/main/java/se/bjurr/violations/comments/lib/CommentsCreator.java#L171

Semyon Levin · Answer 2 · Tue Jul 06 2021 19:08:28 GMT+0800 (China Standard Time)

Thanks! I'm closing the issue.