repeats twice for some reason

Question

repeats twice for some reason

redimongo opened this issue 4 years ago · comments

So I am trying to do something simple which is use needle.get to fetch a pre-roll station ID before it plays the podcast.

It works fine. However here is the issue. according to the logs it is running the code twice.
I am wondering what am I doing wrong as I would like to be able to use the .on('end') to store a database endtime - but i don't need to it run twice.

STATION_ID Completed
754542
STATION_ID Stream END
get POdcast ran
get data connected!
63062853
STATION_ID Completed
754542
STATION_ID Stream END
get POdcast ran
get data connected!
63062853

router.get('/track/:url(*)', (req, res) =>{
    var url = req.params.url.substr(0); 
    var length = 0;
    var clients = [];
    var e = 0;
    /* AD SYS */
    var remote = "https://storage.googleapis.com/ad-system/testfolder/OUTOFAREA.mp3";  
    var adsys = needle.get(remote)
    /* PODCAST */
    var filesize = needle.get(url, function(error, response, body) {
       if(error){
        e = 505;
        res.send("<html><head></head><body>NOPE</body></html>");
        console.log(error)
        //filesize.end();
        res.end();
        
       }
    });

   
        adsys.on('response', function(res) {
            console.error("STATION_ID Completed");
            length =  Number(res.headers['content-length']);
            console.log(length);           
        });

        filesize.on('response', function(res) {
                console.error("get data connected!");
                console.log(res.headers['content-length']);
                a = Number(res.headers['content-length']);
                length = length+a;
                
      });
      res.set({
        "Content-Type": "audio/mpeg",
        'Transfer-Encoding': 'chunk',
    //    'Content-Disposition': 'attachment',
    //    'Content-Length':length
    });

      adsys.on("end", function() {
        
        console.error("STATION_ID Stream END");
       
        getPodcast();
     
        
        //res.end();
    });  


    adsys.on("data", function (chunk) {
            // console.log(clients.length);
            if (clients.length > 0){
                for (client in clients){
                    clients[client].write(chunk);
                    //console.log(chunk);
                };
            }
        
    });

    function getPodcast(){
        console.log("get POdcast ran");
        filesize.on("data", function (chunk) {
            // console.log(clients.length);
            if (clients.length > 0){
                for (client in clients){
                    clients[client].write(chunk);
                    //console.log(chunk);
                };
            }
            
        });
    }
    clients.push(res);
});`
```

Tomás Pollak · Answer 1 · Wed Mar 04 2020 20:00:48 GMT+0800 (China Standard Time)

Try changing adsys.on('end', fn) to adsys.on('done', fn)

RUSSELL HARROWER · Answer 2 · Thu Mar 05 2020 11:07:55 GMT+0800 (China Standard Time)

Try changing adsys.on('end', fn) to adsys.on('done', fn)

I tried this and it still ran twice.
STATION_ID Completed X STATION_ID Stream END get POdcast ran get data connected! 63062853 STATION_ID Completed X STATION_ID Stream END get POdcast ran get data connected!

Tomás Pollak · Answer 3 · Thu Mar 05 2020 11:25:17 GMT+0800 (China Standard Time)

I'm not sure what you're trying to do, but I just ran your code (removing the res calls) and it ran only once:

STATION_ID Completed
754542
get data connected!
undefined
STATION_ID Stream END
get POdcast ran

Are you sure the request isn't being triggered twice? Try logging whenever the '/track/:url(*) route gets called.

RUSSELL HARROWER · Answer 4 · Thu Mar 05 2020 12:43:29 GMT+0800 (China Standard Time)

I'm not sure what you're trying to do, but I just ran your code (removing the res calls) and it ran only once:
STATION_ID Completed
754542
get data connected!
undefined
STATION_ID Stream END
get POdcast ran
Are you sure the request isn't being triggered twice? Try logging whenever the '/track/:url(*) route gets called.

So I took your advice and added

router.get('/track/:url(*)', (req, res) =>{
    var url = req.params.url.substr(0); 
    console.log('/track/'+url);

I figured out the line that is causing the issue:
clients.push(res);

I tried removing the res from that line and it wont load the file in browser or to the user. Any suggestions?

Tomás Pollak · Answer 5 · Thu Mar 05 2020 20:15:12 GMT+0800 (China Standard Time)

Not that I think of now, sorry. :)