tokiclover / mkinitramfs-ll

Lightweight, modular and powerfull initramfs generating tool

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Comments in gnupg.bash

samuraiii opened this issue · comments

I had commented some lines of file gnupg.bash

And then? Closing.... no particular issue.

Ok, then
the script wasnt workinkg properly - hang on showing usage on everey input:
1st is question about line 14
opt=$(getopt -l usage,useflag::,usrdir::,workdir::,version:: -o ud::U::v::W::
should not it be ... usage::,useflag...?
Next line 18
while [[ $# > 0 ]]; do
I see the problem in comparing number of arguments (one is added by script itself)
so while [[ $# > 1 ]]; do ?

Line 38
pushd "${PORTAGE_TMPDIR:-/var/tmp}"/portage/app-crypt/${opts[-gpg]}/work/${opts[-gpg]} || die
would be more convenient ro get from emerge --info like this:
pushd $(emerge --info | grep PORTAGE_TMPDIR | sed 's/PORTAGE_TMPDIR="(.*)"/\1/g')/portage....

Line 39
cp -a gpg "${opts[-usrdir]}"/bin/ || die

I found it in g10/gpg location not in workdir
so cp -a g10/gpg "${opts[-usrdir]}"/bin/ || die

So this is all my comments
S.

And maybe
line 24

 -u|--usage|*) usage;;

to

 -u|--usage) usage;;

Thanks for reporting, this issue will be closed on the next commit.