toeverything / AFFiNE

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.

Home Page:https://affine.pro

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[improvement]: use ENV variables for Firebase

BleedingDev opened this issue · comments

1~3 main use cases of the proposed improvement

Currently API key is publicly in the repository.

Ideas for solution

Just use env variables, it is already used locally for NX_LOCAL, we can set it in Vercel and also locally.

what types of users can benefit from using your proposed improvement

own firebase

Additional context

I already have PoC working with variables. Might open a PR.

hi, all functions of affine do not require a server, the current login feature is only used for authentication in the internal test environment
and firebase's key is designed to allow publish, the permission scope of the key has been strictly limited, and in our use case, it is safe to publish it

Thanks for the answer, would you still be against this improvement if I open a PR?