Should not hardcode the path to facebook.php
igorw opened this issue · comments
It would be better to make the path a pimple parameter (since facebook does not feel like fixing their naming), and also make this optional.
Fixed. Not really sure what you mean about making it optional though?
What I meant was that if no path is provided by the user the facebook sdk should not be included.
But the whole point of this provider is to include the SDK. So if no path is given, then what is the purpose of loading FacebookServiceProvider in the first place?
Maybe I'm missing something though. Have you got a use case to help me get your point?
Well ok you are right, for this extension it really doesn't matter. Nevermind. :)
In general you don't want extensions to automatically include stuff. There could be conflicts between two pieces of code that try to include it. That's all.
Ah, good. Thought perhaps I was missing something.