Giters

tobiasschuerg / InfluxDB-Client-for-Arduino

Simple library for sending measurements to an InfluxDB with a single network request. Supports ESP8266 and ESP32.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Class Point also used in other libraries

walserchr opened this issue · comments

commented

Hi

This is a great library and I really like it. Only thing I want to mention and suggest as an improvement is, that the class Point in the Point.h file is already used in other libraries, e.g. "M5core.h" -> "PointAndZone.h". This makes it very difficult to use in combination with the M5core2, which is a pitty.

Would be nice if this can be improved in a next version :)

Thanks anyway for this library. Great job!

commented

There's no need to go and rename classes, instead include them inside a namespace, e.g.

namespace foo {
    #include "M5Score.h"
}

and then use it like this:

foo::yourClass;
commented

Thank you for the hint, @Dewaeq.

@walserchr, in my defense, this library's Point seems to be older than the one from the M5Core repo.

The term Point has been chosen to comply with the API of other InfluxDB clients.

There is no viable solution for renaming or namespacing the class name to not break compilability with existing code.
As this occurs very rarely (you are the first one reporting it), the workaround by Dewaeq is the best solution.