Large number of shapes causes perf regression with hitTestPoint
mimecuvalo opened this issue · comments
We noticed on a board with a number of shapes that dragging something gets 'stuck' for a couple ticks because we're doing a large # of calculations.
cc @lu
this is the cause of the slowdowns we were seeing
![2222](https://private-user-images.githubusercontent.com/15892272/319567172-5127b66c-1bec-41aa-8c96-ee1060b8d83d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM4OTA0NjUsIm5iZiI6MTcxMzg5MDE2NSwicGF0aCI6Ii8xNTg5MjI3Mi8zMTk1NjcxNzItNTEyN2I2NmMtMWJlYy00MWFhLThjOTYtZWUxMDYwYjhkODNkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDIzVDE2MzYwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEzMTM2ZmUxYmYzNjBlMzVhMzBiZDFkNTdhNTFmMzI3ZTM4ZmFmM2VkZmFkNzIyYWQ3MzJmNDNlZGFiNDAyMDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.yXsJO93k8Y3WNUvGnKViusAGcqKyTpuNaEs6TOoGSWE)
![3333](https://private-user-images.githubusercontent.com/15892272/319567222-87d7b2d9-821c-410e-a308-9725ce6a5f23.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM4OTA0NjUsIm5iZiI6MTcxMzg5MDE2NSwicGF0aCI6Ii8xNTg5MjI3Mi8zMTk1NjcyMjItODdkN2IyZDktODIxYy00MTBlLWEzMDgtOTcyNWNlNmE1ZjIzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDIzVDE2MzYwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRhMGMyZjQwYjE5ZDAyYWNiZDM0OGY3NjgzMjdmNmY0MjgxYzZiYTI3NDZhMTNjODhmZTNmZWVkZDFjYTFjYjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ME8PF6AK2zYGPEuaR-YuFBge63Ez7suDgHfJ4gT_w7I)
and looks like we're pitting everything too, not just notes
https://github.com/tldraw/tldraw/assets/15892272/4f562b75-8993-46e7-94b2-69c5f4847360
thx for investigating @TodePond !