Some smaller things
KillTheMule opened this issue · comments
KillTheMule commented
- This should check for nil also, especially for the sync_request usecase where people probably don't register a callback often.
- Sync requests are async requests with a (busy?) waiting loop. You're waiting 100ms in each step... isn't that much too much?
- Please consider doing this. Note that this is somewhat bad if
value
isnil
, I suggested something about verification in another issue.