tj / connect-redis

Redis session store for Connect

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Stop dependance on legacy mode for redis 4?

paul23-git opened this issue · comments

Well as per title, the legacy mode option might be removed any time from the redis package. As such, and given the fact that redis 4 is quite stable, I think it is important to notice what needs to be changed to no longer depend on legacy mode?

The reason we require legacyMode is that redis@4 changed its API and other Redis implementations (e.g. ioredis) built their APIs to support to original API. Since we support more than just redis as a client, we use this mode. It also wasn't very stable at release so many were using redis@3 and may still be using it (not sure). I think at some point we need to revisit this but I haven't had time to review the various redis implementation to ensure compatibility.

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

This issue was closed because it has been stalled for 5 days with no activity.

I am removing the legacyMode requirement in the next major version of this package. If you want to try it you can npm install connect-redis@next in your projects:

Migration guide in this PR: #377

This issue was closed because it has been stalled for 5 days with no activity.