Feature request: Delete CNAME on container stop
modem7 opened this issue · comments
Heya,
I'm unsure if this is possible at all.
Would it be feasible to delete CNAMEs on containers that no longer exist?
Would be useful for test containers or limited time/scope mini-projects that once their usefulness is done can just be deleted. But obviously currently, the CNAME still stays up on CF.
Thanks!
It's possible, but not entirely reliable, for the following reasons:
-
If a container disappears when this container isn't running, there will be nothing to see the 'stop' event. Even if this container is run afterwards, the DNS record will still exist.
-
There may be some records which exist statically on some peoples setups, so deleting them when you see a traefik enabled container disappearing might be considered dangerous.
I'm happy to submit a PR for this if it would be seen as useful - however I think it should be a toggleable option which is disabled by default. Let me know your thoughts.
There's an active issue in Traefik's issue tracker that has an interesting take on this but in reverse. I'd like to see if it gains any traction before evaluating this. I agree it is fairly risky.
I certainly agree that it should be a variable/option that's disabled by default, forcing this could (and probably would) cause far too many unexpected problems for those not expecting the new functionality.
Alternatively, potentially make it a white list system only, only dealing with the CNAMEs that are declared or similar functionality?
Whitelist sounds interesting. I have hundreds of dev.* domains I'd like to clear out and Cloudflare point click process is tedious.
What makes this extension very useful is that parsing traefik's labels removes the task of updating another label or list. Moving the CNAME identification to somewhere else would defeat the purpose, I think.
However, adding a custom Cloudflare Companion label could open up the ability to set the proxy status or forced update status on a per CNAME basis, which would be very useful.
For deleting obsolete CNAMEs, you could have an environment variable called DELETE_UNDECLARED=TRUE/FALSE, where if TRUE all CNAMEs not declared in traefik labels are deleted.
It's possible to imitate a whitelist by just adding a traefik Host rule to Cloudflare Companion's own container (shout-out to @htpcBeginner for that trick). Alternatively you can add a WHITELIST environment variable to make the whitelisting a bit more integrated.
This would be great if this feature was implemented. I like the idea of having a few more ENV vars to configure it.
Would find it very helpful as well.
Should be configurable!
An option could be to "remember" all domains which where set and on the next run compare. If one is on the "remembered" list, but not in the run to be set, then remove it.