Refactor Tag classes to avoid code duplication

Question

Refactor Tag classes to avoid code duplication

tipsy opened this issue 9 years ago · comments

Currently ContainerTag and EmptyTag share the same 40 convenience methods, but they're manually included in each class. Attempts at refactoring this have been unsuccessful, as I can't seem to find a way to keep the type-information intact (this is important for the fluent-api chaining).

For example, if I move them to Tag (the abstract class they both extend), and do

div().withClass("class").withText(), I run into problems, because withText() should be available for ContainerTag objects, but not EmptyTag objects.

I'm sure there's a way though... any thoughts?

Luiz Henrique Feltes · Answer 1 · Fri Apr 01 2016 23:28:23 GMT+0800 (China Standard Time)

Hi!
I think I could refactor this situation using generics.
This weekend I'll work on this and I'll send you a PR to discuss.

David · Answer 2 · Sat Apr 02 2016 00:16:52 GMT+0800 (China Standard Time)

Cool, looking forward to it!

Luiz Henrique Feltes · Answer 3 · Sat Apr 02 2016 10:07:34 GMT+0800 (China Standard Time)

Take a look on this commit and please tell me what do you think about it.

David · Answer 4 · Sun Apr 03 2016 00:11:05 GMT+0800 (China Standard Time)

Ended up with this. Thanks for your help @snaketl, please let me know if there are any problems with the commit.

Luiz Henrique Feltes · Answer 5 · Sun Apr 03 2016 06:22:09 GMT+0800 (China Standard Time)

I'm glad to help you!