Tag class per HTML element

Question

Tag class per HTML element

mkopylec opened this issue 6 years ago · comments

The API of j2html would become much more type safe if every HTML element had each own representation class that extends either ContainerTag or EmptyTag. Each HTML element class could then have each own set of predefined HTML attributes.
Working with that kind of API would be much more comfortable, but it is quite a lot of work to implement it in j2html. Is there any chance to provide such API or maybe you are open for pull request?

David · Answer 1 · Fri May 18 2018 03:13:04 GMT+0800 (China Standard Time)

@mkopylec I'm always open to pull requests. This change would massively increase the codebase, so please start with a small proof of concept that can be reviewed first.

Edit: Accidentally sent before I finished writing.

Mariusz Kopylec · Answer 2 · Fri May 18 2018 14:50:25 GMT+0800 (China Standard Time)

The amount of code will surely increase, but users of the library will have a lot nicer API to use.
I will create a small PoC.

Mariusz Kopylec · Answer 3 · Fri May 18 2018 17:25:23 GMT+0800 (China Standard Time)

Check out #117

Moandji Ezana · Answer 4 · Thu Jun 28 2018 21:10:50 GMT+0800 (China Standard Time)

This is interesting! I created my own PoC, using JavaPoet to generate the code: #121

Deleted user · Answer 5 · Thu Oct 17 2019 18:48:50 GMT+0800 (China Standard Time)

@mkopylec There are other APIs providing such features (including htmlFlow), maybe j2html's developers prefer keeping it simple.

Mariusz Kopylec · Answer 6 · Thu Oct 17 2019 21:45:57 GMT+0800 (China Standard Time)

@gouessej It looks promising, thanks.

Deleted user · Answer 7 · Sun Oct 20 2019 02:54:48 GMT+0800 (China Standard Time)

@mkopylec You're welcome. Feel free to try my flowifier, I've just tested against Wikipedia's homepage, it helps to generate some Java source code from existing HTML source code.