Add a default limit of 1000

Question

Add a default limit of 1000

timothyclemansinsea opened this issue 8 years ago · comments

The default $limit on Socrata is 1000. https://dev.socrata.com/docs/queries/

Tim Wisniewski · Answer 1 · Mon Apr 11 2016 22:33:26 GMT+0800 (China Standard Time)

Are you suggesting that if $limit is not specified, the resulting SQL should always include LIMIT 1000? That doesn't seem to fit, unless I'm misunderstanding.

Tim Clemans · Answer 2 · Tue Apr 12 2016 00:44:15 GMT+0800 (China Standard Time)

Yes. This is the behavior of Socrata's implementation. I got interested in
it because I realized if I didn't add $limit that I was getting all rows.

On Mon, Apr 11, 2016 at 7:33 AM, Tim Wisniewski notifications@github.com
wrote:

Are you suggesting that if $limit is not specified, the resulting SQL
should always include LIMIT 1000? That doesn't seem to fit, unless I'm
misunderstanding.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#6 (comment)

Tim Wisniewski · Answer 3 · Tue Feb 07 2017 20:10:32 GMT+0800 (China Standard Time)

I've opted to do this in the layer above this one. I can see the argument for it living in node-soda2-parser, but (a) considering it will affect all of the tests of this repo and any layer above it, and (b) considering other providers may warrant an even narrower limit, I think it makes more sense it to leave it at the layer above this for now.