Giters

timthedevguy / BuySYS

*NO LONGER MAINTAINED* Buyback application for EveOnline, can be used by Corporations/Alliances or private entities. Written in PHP 7.4

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rules ignored for Advanced Crystals

unixg33k opened this issue · comments

commented

Hello and thank you again for this great software. I was on AmSYS then moved to BuySYS and it's been working perfectly so far.

Strange thing with crystals though today, I'm probably doing it wrong. All of our other rules work correctly, but if we put in a rule for the entire group "Frequency Crystals" to set price to 0, it works for all frequency crystals except advanced beam and advanced pulse. Rule tests will work on them, but actual price quotes to the end user show the normal price.

Process:
Add rule for set price on Frequency Crystals to 0
Refresh cache
Rule test for all types of crystals works as expected
Faction and normal crystals working for seller estimates
Advanced crystals not showing 0 for seller estimates
Set the rule to the highest spot
Add a rule for Advanced Beam group, add rule for Advanced Pulse group
Set the rule to the highest spot
Refresh cache
Still persists
Add items in manually - Conflagration M, Aurora S
Refresh cache
Still persists

Am I doing something wrong?

Thanks

commented

Apologies I saw this the day you sent it, read it, and got busy with work and forgot, looking again

commented

Ok unixg33k, it finally dawned on me what is wrong.

Simple fix. Set the rule for 'Advanced Pulse Laser Crystal' to CanBuy = No. Price = 0 does not work because 0 is the default value of an empty number. So the system checks if Price is greater than 0 and relies on the CanBuy = No for blocking purchase of an item.