Add errors/warning where we're sure that an error could be
timocov opened this issue · comments
Related to #8 (comment)
Needs to revert changes for #5 and warn about using in operator for internal types (that's ok for public types).
Depends on microsoft/TypeScript#36733
Quite possible that we need to revert changes from dc11196 and warn about defining properties because at least terser doesn't support properties renaming defined in Object.defineProperty. From the docs https://terser.org/docs/cli-usage#cli-mangling-property-names-mangle-props:
Avoid calling functions like defineProperty or hasOwnProperty, because they refer to object properties using strings and will break your code if you don't know what you are doing.
So I guess we need to check whether a compilation require to use defineProperty to define properties and whether this property is internal and then warn about that.
Terser supports mangling properties defined in defineProperty so it's irrelevant.
/cc @artfiedler
I believe those docs are out of date, I had verified terser worked, I had the latest version of terser
Yep, I've tested it after posting my comment and it works fine.
Related to terser/terser#748
Avoid calling functions like defineProperty or hasOwnProperty, because they refer to object properties using strings and will break your code if you don't know what you are doing.
This is merely to warn people who don't understand the limitations. I got tons of issues which assumed Terser did full flow analysis (which it doesn't).
Ideally I would love property mangle to work more safely, and using typescript typing information to achieve this is a great idea!