Tags should not be prepended with 'v', fails SPM

Question

Tags should not be prepended with 'v', fails SPM

terwanerik opened this issue 5 years ago · comments

Hi,

Xcode 11 finally has SPM support built-in, so adding SPM packages to iOS / macOS is now possible without much hassle.

The current Package.swift works fine for this, there is only one issue, Xcode cannot find version 3.0.0 because it's tagged as v3.0.0 in the releases/tags.

The only way to add the framework now is by selecting the master branch, ideally not what you'd want.

Can version v3.0.0 be tagged again as 3.0.0 and further versions from here on out? So we can use the 'power' of semver.

Thanks!

Tim Donnelly · Answer 1 · Fri Oct 18 2019 21:38:59 GMT+0800 (China Standard Time)

Good catch, thanks! I'll remove the v moving forward.

Tim Donnelly · Answer 2 · Fri Oct 18 2019 21:44:44 GMT+0800 (China Standard Time)

I've added a 3.0.0 tag, please let me know if you have any more problems.

Erik Terwan · Answer 3 · Fri Oct 18 2019 22:40:37 GMT+0800 (China Standard Time)

It fails because there is no Package.swift manifest in the tagged version. If you download the tag as a zip file, you'll notice the Package.swift file is missing.

Tim Donnelly · Answer 4 · Fri Oct 18 2019 23:20:04 GMT+0800 (China Standard Time)

I went ahead and released 3.1.0, which I have verified is working in another project.