Add immer implementations of @ngrx/signals
timdeschryver opened this issue · comments
Coming from ngrx/platform#3998
@timdeschryver Hi, any update for this feature?
@xianshenglu this needs to be implemented 😅
If you want to contribute, feel free to drop your a comment here and it will get assigned to you
@rainerhahnekamp I'm assigning this to you.
I've added the "infrastructure" so you can focus on the "good stuff".
Feel free to ping me if you need help.
Alright, thanks Tim and I'll contact you if I have any questions or just push the PR once it is ready
Quick update here. PR should be ready by tomorrow. Should give us enough time for a proper review and improvements before Marko's talk at ng-conf.
Thanks @rainerhahnekamp
@timdeschryver, there is a little bit of a problem with the testing. To verify that only the patched Signals emit, I need to use TestBed.flushEffects().
I'll have to add Jest in that case. I prefer Jasmine, but that might be an overkill.
@timdeschryver, there is a little bit of a problem with the testing. To verify that only the patched Signals emit, I need to use
TestBed.flushEffects().I'll have to add Jest in that case. I prefer Jasmine, but that might be an overkill.
That's fine, feel free to use jest for this.
Closed by #24