Giters

timacdonald / json-api

A lightweight API resource for Laravel that helps you adhere to the JSON:API standard. Supports sparse fieldsets, compound documents, and more.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Package requires Laravel framework instead of Illuminate packages

DannyvdSluijs opened this issue · comments

commented

As highlighted in composer.json

json-api/composer.json

Line 20 in c3f89ee

"laravel/framework": "^8.0 || ^9.0"
this package requires laravel/framework.

Trying to use this package in a Luman application is resulting in Illuminate packages being removed and laravel/framework being installed as its replacement causing some application issues.

I think it would be relatively easy to replace the dependencies for the sub packages of Laravel framework. Before creating such an PR I wanted to check if you would be accepting pull requests for this?

commented

I should be able to do this for sure. Will look at that shortly.

commented

I took the time to at least make the code changes that I think should be required in order to support Lumen. Changes still need to be tested.

commented

Gonna close this one and track in the PR. Thanks!