Support Detector2 interface

Question

Support Detector2 interface

KengoTODA opened this issue 11 years ago · comments

Hi ALL,

currently I want to use this library to test a FindBugs plugin which implements Detector2 interface. I can provide a patch for this issue, but this library looks inactive, so I am afraid that you will not check and merge it.

Can you review, merge my pull request and deploy new version into Maven central repository?
If you can, I will send a patch for you (and this is the best plan for me). If you cannot, I will fork this library and try to deploy with another groupId.

Thanks in advance.

Graham Allan · Answer 1 · Wed Jul 03 2013 22:27:43 GMT+0800 (China Standard Time)

Hi eller86,

Apologies for not responding sooner. I do intend for this project to be active, and to respond to issues like this. I will need to check GitHub notification settings to figure out why I didn't receive an email.

I'll take a look at the pull request and update here.

Thanks!

Kengo TODA · Answer 2 · Wed Jul 03 2013 22:46:21 GMT+0800 (China Standard Time)

Thanks, I made #9 so please check it. When you find some problem, I will fix it ASAP.
I hope you will merge it and publish new version onto Maven central later.

I know that many GitHub user cannot get notification, maybe GitHub has changed some implementation.

Graham Allan · Answer 3 · Sun Jul 14 2013 21:38:54 GMT+0800 (China Standard Time)

Hi @eller86

Just a heads up, I realised there was a typo in the method names. I wanted to fix this before releasing next version, but this will be a source incompatible change for you (hopefully trivial to fix though).