tilezen / vector-datasource

Tilezen vector tile service - OpenStreetMap data in several formats

Home Page:https://www.nextzen.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Cleanup 7 remaining integration test failures

nvkelso opened this issue · comments

Down to just 8 failures (down from 60)!

FAIL: test_cycleway_with_international_route (integration-test.1170-very-early-paths-and-bike-routes.VeryEarlyPathsAndBikeRoutes)
AssertionError: Did not find feature including properties {'kind': 'path', 'is_bicycle_related': True, 'bicycle_network': 'icn'} (because layer 'roads' was empty)

======================================================================
FAIL: test_path_with_international_route (integration-test.1170-very-early-paths-and-bike-routes.VeryEarlyPathsAndBikeRoutes)
AssertionError: Did not find feature including properties {'kind': 'path', 'walking_network': 'iwn'} (because layer 'roads' was empty)

======================================================================
FAIL: test_path_with_national_route (integration-test.1170-very-early-paths-and-bike-routes.VeryEarlyPathsAndBikeRoutes)
AssertionError: Did not find feature including properties {'kind': 'path', 'walking_network': 'nwn'} (because layer 'roads' was empty)

======================================================================
FAIL: test_full_lists_disappear_by_zoom_12 (integration-test.1194-bus-route-refs.BusRouteRefs)
AssertionError: Did not find feature including properties {'bus_network': <type 'NoneType'>, 'bus_shield_text': None} (because layer 'roads' was empty)

======================================================================
FAIL: test_driveway_nwn (integration-test.596-add-hiking-routes.AddHikingRoutes)
AssertionError: Did not find feature including properties {'kind_detail': 'service', 'kind': 'minor_road', 'walking_network': 'nwn', 'service': 'driveway'} (because layer 'roads' was empty)

======================================================================
FAIL: test_minor_road_nwn (integration-test.596-add-hiking-routes.AddHikingRoutes)
AssertionError: Did not find feature including properties {'kind_detail': 'residential', 'kind': 'minor_road', 'walking_network': 'nwn'} (because layer 'roads' was empty)

======================================================================
FAIL: test_service_nwn (integration-test.596-add-hiking-routes.AddHikingRoutes)
AssertionError: Did not find feature including properties {'kind_detail': 'service', 'kind': 'minor_road', 'walking_network': 'nwn'} (because layer 'roads' was empty)

Originally posted by @nvkelso in #2016 (comment)

@nvkelso
I would like to point out that some recent changes introduced more integration tests failures. Attention that the linters check is important, if the linter tests failed it won't run the integration tests and may hide the problems. One we way can do is to change the settings of the repo so that each merge have to rebase master before merging. Also to have a clearer view on which commit breaks things, we might want to try squash and merge instead of merge request, otherwise the history of commit on master are interleaved with older commits from a PR once it was merged.

If we scan the master branch and use this commit as baseline cab179d it had 8 integration tests failures

then this commit 5dfc1d1 increased it to 90

then this commit d8b7dbe might be the one that increased it to 91 (cc @iandees )

and now at the time of writing the number is 92 according to #2036
it might be introduced by #2015