Giters

tilda / genshin-recipe-data

An attempt to keep a current copy of Genshin Impact's cooking recipe data

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rework data to not be a big blob and have more information

tilda opened this issue · comments

commented

So, thinking about it, there is a lot of room for improvement in how this repository is structured.

Some things to think about:

  • Adding a "region" flag, probably as an int e.g. 0 being mond, 1 being liyue, etc
    • Reason for it being an int: Localization support. i.e. Mondstadt is differently localized in both Chinese variants, Japanese, and Korean. So it makes sense.
  • Separating each recipe into its own JSON file, then running some sort of build process to combine all files
    • This could allow for contributing & maintaining the dataset to be MUCH smoother
    • Also allows for much better localization support if that ever comes to fruition.
  • Event exclusive flag
    • There are plenty of event-locked recipes, so maybe having another field for that instead of wasting space in the location field would be good.