Remove generics in key_builder
garrensmith opened this issue ยท comments
The Key_builder supports generics to allow schema.Field
or schema.QueryableField
. This should be removed and key_builder
should only accept schema.QueryableField
.
Steps to get this working:
- Remove generics in key_builder
- Fix tests to only accept
schema.QueryableField
this could be done by converting the currentschema.Field
options into aqueryableField
before running the test - Add a method on
schema.DefaultCollection
to get the primarykeys as a list of queryablefields
I'll pick this up
Awesome @karuppiah7890 I've assigned the ticket to you. Ping me here or in discord if you need help.
Related Discord discussion thread - https://discord.com/channels/1033842669983633488/1033843208192524348/1095960587806183494
๐ This issue has been resolved in version 1.0.0-beta.90 ๐
The release is available on GitHub release
Your semantic-release bot ๐ฆ๐