Docker images out of date

Question

Docker images out of date

jenswet opened this issue 4 years ago · comments

Jens Wetterich commented 4 years ago

Hello,

the docker CI build is not triggered anymore and the images in the hub are out of date.

Would be great if they can be updated again @tiangolo

Thanks!

rozacek · Answer 1 · Tue Jul 07 2020 21:28:54 GMT+0800 (China Standard Time)

I noticed the same problem.
Currently fastapi version in images is: 0.55.1 what is very confusing when goes on working with root_path feature: https://fastapi.tiangolo.com/advanced/behind-a-proxy/ as it's supported since 0.56.0!!! I lost a day due to that fact :(

Jens Wetterich · Answer 2 · Tue Jul 28 2020 14:50:07 GMT+0800 (China Standard Time)

@tiangolo Can you trigger a new build please?

graue70 · Answer 3 · Wed Oct 14 2020 21:56:28 GMT+0800 (China Standard Time)

In the meantime, you can use this:

FROM tiangolo/uvicorn-gunicorn:python3.8

RUN PIP_NO_CACHE_DIR=1 \
    PIP_DISABLE_PIP_VERSION_CHECK=1 \
    pip install fastapi

# ...

COPY ./app /app

It is inspired by the original Dockerfile. Of course, it only works for uvicorn-gunicorn tags which are supported (particularly, it doesn't currently work for python 3.9 or for any python version with alpine higher than 3.10).

Maz · Answer 4 · Tue Nov 10 2020 16:46:06 GMT+0800 (China Standard Time)

Starlette samesite keyword argument on set_cookie is also missing due to outdated images. 🙇‍♂️

Sebastián Ramírez · Answer 5 · Thu Nov 10 2022 03:41:02 GMT+0800 (China Standard Time)

Thanks for the discussion here everyone! I think this was triggered/handled a while ago, right?

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

Justin · Answer 6 · Thu Nov 10 2022 05:21:03 GMT+0800 (China Standard Time)

Thanks for the discussion here everyone! I think this was triggered/handled a while ago, right?

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

@tiangolo, is this an automated reply?

Don't think so. Appears that the Python3.9 release is still the latest image available, from over a year ago, but I'm no longer relying on this image, in favor of my own. I see there are recent commits to uvicorn-gunicorn repo however, including a 3.10 branch.

Sebastián Ramírez · Answer 7 · Thu Nov 10 2022 06:07:17 GMT+0800 (China Standard Time)

No, it's not an automated reply, the discussion was about new runs of the image builds, not Python versions.

And yep, indeed, you should probably rely on your own image, you probably don't need this one as explained in the README: https://github.com/tiangolo/uvicorn-gunicorn-fastapi-docker#-warning-you-probably-dont-need-this-docker-image

I'm glad you found a solution for your use cases. 👍

Justin · Answer 8 · Thu Nov 10 2022 06:56:43 GMT+0800 (China Standard Time)

the discussion was about new runs of the image builds, not Python versions.

Yup, egg on my face. Was distracted as to the subject mater I guess. Cheers.

github-actions · Answer 9 · Sun Nov 20 2022 08:28:21 GMT+0800 (China Standard Time)

Assuming the original issue was solved, it will be automatically closed now. But feel free to add more comments or create new issues.