updating to latest version fails to compile and error as dependency missing

Question

updating to latest version fails to compile and error as dependency missing

sheikalthaf opened this issue 4 years ago · comments

Describe the bug
after upating to latest version I'm getting this error

ERROR in The target entry-point "material-community-components/color-picker" has missing dependencies:
 - @thebespokepixel/es-tinycolor
 - tinycolor2

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

aceleghin · Answer 1 · Mon Sep 21 2020 18:05:43 GMT+0800 (China Standard Time)

Same error here, old import seems not exists anymore (in the doc I still see the v7 with this import:
import {MccColorPickerModule} from 'material-community-components' )
With the new import I have the same missing dependencies
Already tried to delete node modules but nothing changed.
I have angular 10.1.2

Markus Mohoritsch · Answer 2 · Mon Sep 21 2020 23:08:46 GMT+0800 (China Standard Time)

Hi. There is in fact a new peer dependency not packaged with the lib @thebespokepixel/es-tinycolor used for all the color calculations in the color-picker. This is missing in the docs and README.md and also the docs and demo are still on 7.0.0. The breaking change about secondary imports also should have been statet in the changelog. Sorry for that.

@tiaguinho can you update the demo? I already took care of the missing docs about new import method and peer dependency: #173

Jordan Harrison · Answer 3 · Tue Sep 22 2020 06:21:13 GMT+0800 (China Standard Time)

Same error here, old import seems not exists anymore (in the doc I still see the v7 with this import:
import {MccColorPickerModule} from 'material-community-components' )
With the new import I have the same missing dependencies
Already tried to delete node modules but nothing changed.
I have angular 10.1.2

It looks like you import from subfolders now:
import { MccColorPickerModule } from 'material-community-components/color-picker';

Markus Mohoritsch · Answer 4 · Tue Sep 22 2020 22:12:47 GMT+0800 (China Standard Time)

Thats correct

Erik Holman · Answer 5 · Tue Sep 29 2020 19:46:15 GMT+0800 (China Standard Time)

@tiaguinho There is a good need for updated demo's/documentation.

Another error:

ERROR in src/app/shared/components/input/input.component.html:20:23 - error TS2322: Type '""' is not assignable to type '"openOnFocus" | "default"'.

20       <input matInput mccColorPickerOrigin #trigger="mccColorPickerOrigin" [formControlName]="controlName"  />

which should become either
<input matInput mccColorPickerOrigin="openOnFocus" #trigger="mccColorPickerOrigin" [formControlName]="controlName" /> or <input matInput mccColorPickerOrigin="default" #trigger="mccColorPickerOrigin" [formControlName]="controlName" />

I like the feature openOnFocus though 👍

Markus Mohoritsch · Answer 6 · Wed Sep 30 2020 23:22:38 GMT+0800 (China Standard Time)

@eholman the error appears only when having "strictTemplates" = true in your angularCompilerOptions.

I'll try to change the types to work with strict template type checks.

EDIT: i maybe found a solution already:
https://angular.io/guide/template-typecheck#troubleshooting-template-errors
https://angular.io/guide/template-typecheck#input-setter-coercion

Markus Mohoritsch · Answer 7 · Thu Oct 01 2020 00:30:26 GMT+0800 (China Standard Time)

5a1a341 should fix all error showing up due to strictTemplates checks

Markus Mohoritsch · Answer 8 · Tue Oct 06 2020 20:28:38 GMT+0800 (China Standard Time)

All changes are now documented and https://github.com/tiaguinho/material-community-components/releases/tag/v9.0.1 is released so this can be closed i think

Markus Mohoritsch · Answer 9 · Thu Oct 08 2020 06:23:50 GMT+0800 (China Standard Time)

The demo is now up to date:
https://tiaguinho.github.io/material-community-components/

Erik Holman · Answer 10 · Fri Oct 09 2020 19:14:02 GMT+0800 (China Standard Time)

5a1a341 should fix all error showing up due to strictTemplates checks

Good move and great job!

aceleghin · Answer 11 · Thu Oct 15 2020 00:25:05 GMT+0800 (China Standard Time)

I still see tinycolor2 missing dependencies

Markus Mohoritsch · Answer 12 · Thu Oct 15 2020 18:33:34 GMT+0800 (China Standard Time)

@lippomano @sheikalthaf It seems as if an import from @types/tinycolor2 in the lib is causing this. Could you try if the error disapears if you add that to your devDependencies. I also changed the import to an type-only import import type { Instance } from 'tinycolor' in #181. I hope it helps.

Tiago Temporin · Answer 13 · Fri Oct 16 2020 20:50:29 GMT+0800 (China Standard Time)

Thanks @motabass
@lippomano can you check with v9.0.2?

Markus Mohoritsch · Answer 14 · Mon Oct 19 2020 15:40:53 GMT+0800 (China Standard Time)

@tiaguinho 9.0.2 has _theming.scss missing!!

Tiago Temporin · Answer 15 · Mon Oct 19 2020 17:50:00 GMT+0800 (China Standard Time)

@motabass I just publish a new version fixing this.
Thanks

@lippomano can you check version v9.0.3?

Uladzislau · Answer 16 · Tue Oct 20 2020 15:52:45 GMT+0800 (China Standard Time)

@tiaguinho Installed v 9.0.3 and installed additionally @thebespokepixel/es-tinycolor v 2.1.1
Keeps giving me this:

ERROR in node_modules/material-community-components/color-picker/color-picker.types.d.ts:2:13 - error TS1005: '=' expected.

2 import type { Instance } from 'tinycolor2';
              ~
node_modules/material-community-components/color-picker/color-picker.types.d.ts:2:31 - error TS1005: ';' expected.

2 import type { Instance } from 'tinycolor2';

Markus Mohoritsch · Answer 17 · Tue Oct 20 2020 20:12:32 GMT+0800 (China Standard Time)

@VladMstv which TypeScript version are you using? Seems to have no support for Type-only imports.

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html

Uladzislau · Answer 18 · Tue Oct 20 2020 20:16:40 GMT+0800 (China Standard Time)

@VladMstv which TypeScript version are you using? Seems to have no support for Type-only imports.

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html

@motabass
Yeah, seems like that, 3.7.5. I'll try to upgrade it.

Dev LFM · Answer 19 · Fri Oct 30 2020 07:13:31 GMT+0800 (China Standard Time)

Hi, I'm also having this problem.. 9.0.3 didn't fix it.
I need the fix for the drag outside box on color picker, if there's another release with that fix I'm ok with that.

Angular CLI: 9.1.12
Node: 12.19.0
OS: linux x64

Angular: 9.1.12
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.901.12
@angular-devkit/build-angular     0.901.12
@angular-devkit/build-optimizer   0.901.12
@angular-devkit/build-webpack     0.901.12
@angular-devkit/core              9.1.12
@angular-devkit/schematics        9.1.12
@angular/cdk                      9.2.4
@angular/flex-layout              9.0.0-beta.31
@angular/material                 9.2.4
@ngtools/webpack                  9.1.12
@schematics/angular               9.1.12
@schematics/update                0.901.12
rxjs                              6.6.3
typescript                        3.8.3
webpack                           4.42.0

Markus Mohoritsch · Answer 20 · Mon Nov 02 2020 05:27:46 GMT+0800 (China Standard Time)

Being on typescript > 3.8 and adding @types/tinycolor2 to your devDependencies should fix it for now.

belivo · Answer 21 · Tue Nov 17 2020 06:30:19 GMT+0800 (China Standard Time)

On a clean install I get this compilation error:

ERROR in node_modules/material-community-components/color-picker/color-picker.types.d.ts:41:29 - error TS2709: Cannot use namespace 'Instance' as a type.

41 export declare type Color = Instance;

Tiago Temporin · Answer 22 · Wed Nov 18 2020 17:06:57 GMT+0800 (China Standard Time)

@belivo which Angular and MCC version are you using?

belivo · Answer 23 · Fri Nov 20 2020 01:44:59 GMT+0800 (China Standard Time)

@tiaguinho
"@angular/cli": "10.1.7"
"typescript": "4.0.3"
I think it was version 9.0.3

André · Answer 24 · Thu Aug 12 2021 03:46:30 GMT+0800 (China Standard Time)

no solution jet?

An error occurred during the build:
Error: The target entry-point "material-community-components/color-picker" has missing dependencies:
 - @thebespokepixel/es-tinycolor

    at TargetedEntryPointFinder.findEntryPoints (...\node_modules\@angular\compiler-cli\ngcc\src\entry_point_finder\targeted_entry_point_finder.js:40:23)

dependency:

Angular 12.2
material-community-components 11.0.0

dev-dependency:

@types/tinycolor2 1.4.3