VF labeled instances have incorrect stylenames
thundernixon opened this issue · comments
Stylenames don't include width descriptions.
This is partly because the designspace doesn't have correct stylenames declared in instances. For example, the instance with axis values and file naming for a "SemiBold Condensed" style simply has stylename="SemiBold"
However, this is a generated designspace document, so it probably is an issue in the Glyphs file setup, or potentially in FontMake. I'll know more when I can better understand how the data is transformed into a designspace document.
In the original Glyphs file, instances do not contain full values for their Style Name. This is likely the root cause of the issue.
Could also be related to the generated designspace having
stylemapfamilyname="Encode Sans SemiCondensed ExtraLight"(with a weight and width style name on the family, rather than just the family name)stylemapstylename="regular"on all instances
etc
The <map> is working to morph weight values to the 100–900, based on the fact that leaving the <map> and changing a heavy value to 900 gives the following error:
AssertionError: Location for axis 'Weight' (mapped to 1568.0) out of range for 'Encode Sans Condensed Black' [100.0..900.0]
When these values are edited in the designspace and used to run FontProject, it does correct the style naming (though weirdly, the ordering of these names doesn't match with my expectations):
In the original Glyphs file, instances do not contain full values for their Style Name. This is likely the root cause of the issue.
I guess that's because they have an instance Custom Parameter to set the family name, to output correct static instances.
I guess you might need to go sources to VF to static instances, instead of dual source to VF and source to static instances...
Sorry, I should have updated this issue, but I do think the instance names are that way in the Glyphs file to output the static instances in different widths.
@mjlagattuta's build scripts had a smart method for a <name> patch with sed. I've updated this for Encode VF, and it's working much better now! I can export from the same Glyphs source, and the names sort as expected in FontView.
