thunderer / Shortcode

Advanced shortcode (BBCode) parser and engine for PHP

Home Page:http://kowalczyk.cc

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[] Does not work inside a shortcode

jenstornell opened this issue · comments

I've been trying really hard to break this thing. It was not easy but I found a way to break it.

Shortcodes like this will not work:

[characters]
    []
[/characters]

If the brackets has characters like [sada], the characters shortcode works as expected. It's only when it's empty it does not work. In that case it just leave it unparsed.

On the upside I tried '"_åäö and other strange characters which works fine.

Hi @jenstornell, thanks for the report. This issue should be fixed in #60, could you please check whether it solves your problem? You can install dev-issue58-fix-opening-token-check version in Composer which will load the feature branch into your project. Also, any comments on the PR would be welcome.

@jenstornell have you had a chance to look at my fix? I'll happily merge it, but maybe you found another edge cases or something, I want to be sure that it solves all your issues.

Nope, not yet. But if you get the same issue before and got rid of it, then it probably works? Maybe you can add that case to your tests.

I don't have my code environment ready right now, but I'll get back here when I do.

I close this as you opened #60.