thunderer / Shortcode

Advanced shortcode (BBCode) parser and engine for PHP

Home Page:http://kowalczyk.cc

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

RegularParser not working with HTML content

leonardoalifraco opened this issue · comments

The Regular parser is not working when having HTML content on shortcodes.

Example:

$handlers->add($emptyCustomTag, function (ShortcodeInterface $s) {
    return '';
});
$processor = new Processor(new RegularParser(), $handlers);
$processor->process("[isolated-block]<a>Hola</a>[/isolated-block]");

Returns

<a>Hola</a>[/isolated-block]

I'm sorry, I fixed this issue recently on dev-master but forgot to release new version. Just published v0.6.2 and tested that it works correctly. Please confirm that it works for you and possibly close the issue.

Thanks a lot!

Hi @thunderer
Looping back on this. I've shared this package with a colleague and he got the same issue.
Then we realised that the version to require specified on the readme is not the latest.

What do you think of switching to ^0.6 on the readme.md?

Why even name a specific version there? Composer will automatically pick the latest possible version when you just call composer require thunderer/shortcode ;)

@leonardoalifraco yes, it would be a good change, but the command mentioned by @jdreesen will update Shortcode to the latest version (it will also update entry in composer.json).

I mean, in the installation instructions it reads:

to install it execute:

composer require thunderer/shortcode ^0.5

or manually update your composer.json with:

(...)
"require": {
    "thunderer/shortcode": "^0.5"
}

Updating the version number to the latest available or removing it at all would be acceptable solutions from my point of view.

@lalifraco-devspark yes, I understand what you mean, just did it in latest changeset d961fca .