Linux line ending gets duplicated when copying with Wayland

Question

Linux line ending gets duplicated when copying with Wayland

rugk opened this issue 5 years ago · comments

Bug Description

Steps to Reproduce (for bugs)

Copy:

an example
second paragraph

Paste into message box. You get:

an example
second paragraph

fine.
3. Ctrl+A + Copy that text again.
4. Paste somewhere else or in the same message box (Ctrl+V). You get:

an example

second paragraph

Potential Solution

It's likely due to how linefeed character conversion is handled…

Your Environment

Threema Web version: 2.3.0-gh (new issue with that version, AFAIK)
Browser name and version: Firefox 71
Computer operating system and version: Linux/Fedora (GNOME)

Background info

(potentially useful for usability improvements/UX stuff)

Why am I even doing this? (Copy & pasting in the compose box in the same chat?)
I do know it autosaves chats when switching and usually notice that.

However, I did it here, because in the same chat the topic was switched while I was writing ("composing") a message and thus I wanted to quickly reply to that new message, keeping my old "draft message". So to avoid to loose the message I copy it and keep it in my clipboard; write the reply, send it and finally paste the old message again to continue writing.

I do exactly the same in the Android app (also copy all and paste later).

This just FYI, maybe the clipboard and as I do it is already the best way to solve this problem, maybe it is not. 🤔

Danilo Bargen · Answer 1 · Wed Dec 18 2019 16:29:15 GMT+0800 (China Standard Time)

I cannot reproduce this issue on 2.3.0, neither with Firefox (70) nor with Chrome (78).

Can you reproduce the issue if you copy the text above from GitHub?

Does it also happen if you manually enter 2 lines of text, then copy&paste that text?

Lenny · Answer 2 · Wed Dec 18 2019 16:52:34 GMT+0800 (China Standard Time)

I can reproduce it.

Danilo Bargen · Answer 3 · Wed Dec 18 2019 20:27:25 GMT+0800 (China Standard Time)

I can reproduce it.

You've earned yourself an assignment 😄

I updated to FF 71, but still can't reproduce it.

Danilo Bargen · Answer 4 · Wed Dec 18 2019 20:27:36 GMT+0800 (China Standard Time)

@rugk do you use Wayland?

Danilo Bargen · Answer 5 · Wed Dec 18 2019 20:37:29 GMT+0800 (China Standard Time)

It seems to be a Firefox bug, since the newline is also there if you paste into a text editor.

@rugk Does it also happen in Chrom(e|ium)?

rugk · Answer 6 · Wed Dec 18 2019 22:11:47 GMT+0800 (China Standard Time)

Yes Wayland, Chrome/ium not tested.

Danilo Bargen · Answer 7 · Wed Dec 18 2019 23:04:18 GMT+0800 (China Standard Time)

Ok, I strongly suspect a bug in Firefox, potentially related to Wayland (since the clipboard is something that's handled differently in X and Wayland). I fear there's not much we can do about it. We do not intercept copying in any way.

rugk · Answer 8 · Wed Dec 18 2019 23:05:53 GMT+0800 (China Standard Time)

Hmm, it worked before and has definitively been introduced with the Threema Web update to v2.3.0 🤔

It also happens in no other web application (e.g. in GitHub here). 🤔

So there must be something.

ovalseven8 · Answer 9 · Wed Dec 18 2019 23:07:57 GMT+0800 (China Standard Time)

Perhaps try git bisect?

Danilo Bargen · Answer 10 · Wed Dec 18 2019 23:08:53 GMT+0800 (China Standard Time)

Hmm, it worked before and has definitively been introduced with the Threema Web update to v2.3.0

You can compare with older versions here: https://web.threema.ch/archive/ The current compose area was introduced in 2.2.0, so it doesn't make sense to test older versions.

It might be caused by the fact that we set white-space: pre-wrap in Threema which GitHub does not use.

Can you confirm that the additional newline is already present when copying (e.g. by pasting the text into a text editor) and that it's not added by pasting?

rugk · Answer 11 · Thu Dec 19 2019 00:54:47 GMT+0800 (China Standard Time)

Can you confirm that the additional newline is already present when copying (e.g. by pasting the text into a text editor) and that it's not added by pasting?

I tested it again and no, not really…

STR:

paste "text\ntext"
copy into text editor -> it's not there (still "text\ntext")
paste the copied text again into Threema Web (still looks okay)
copy again into text editor -> "text\n\ntext"

So it seems to be added by pasting (but only on the second try??), actually…

Also checked the HTML source code. During the STRs in this comment, it always stays one single <br> between the lines and is also displayed correctly in the web version. 🤔

rugk · Answer 12 · Mon Dec 23 2019 18:34:07 GMT+0800 (China Standard Time)

It might be caused by the fact that we set white-space: pre-wrap in Threema which GitHub does not use.

Indeed, if I disable white-space: pre-wrap;, it does work.

rugk · Answer 13 · Mon Dec 23 2019 18:36:49 GMT+0800 (China Standard Time)

But it is not the cause, because if I set white-space: pre-wrap; in GitHub, it is not reproducible.

I can also reproduce this on https://threema-ch.github.io/compose-area/.

rugk · Answer 14 · Mon Dec 23 2019 20:55:44 GMT+0800 (China Standard Time)

Okay, confirmed to be unreproducible with Xorg.

Reported at

Fedora's bug tracker: https://bugzilla.redhat.com/show_bug.cgi?id=1786104
Mozilla's bug tracker: https://bugzilla.mozilla.org/show_bug.cgi?id=1605715

Danilo Bargen · Answer 15 · Tue Dec 24 2019 00:10:37 GMT+0800 (China Standard Time)

Thanks for the reports! Since I now have a new laptop that can also run Wayland (thanks to absence of an Nvidia graphics card), I can confirm that the bug is reproducible, but only when running Firefox with Wayland support (MOZ_ENABLE_WAYLAND=1), not when using XWayland.