thoughtworks / build-your-own-radar

A library that generates an interactive radar, inspired by https://thoughtworks.com/radar/.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Chrome not prompting for Google Sheet authentication, even when pop-ups allowed

jacobmclocklin opened this issue · comments

Hello -

We use BYOR hosted on radar.thoughtworks.com. We supply a Google Sheet that requires authentication. A while ago (1+ months), all browsers would successfully request authentication from Google for our Sheet, as long as pop-ups were allowed for the current URL. However, now Chrome will not prompt for authentication at all. I have double-checked that pop-ups are allowed.

Firefox and Safari are prompting for authentication correctly, and the radar renders correctly.

Hey @jacobmclocklin! Thanks for bringing this to our attention. In Chrome, when the pop-up doesn't show up, does the page just keep saying it's loading? If not, what's the experience?

@jacobmclocklin Thanks for the info! I'm actually getting similar behavior when I try a private sheet, which used to work for me — and, a public sheet doesn't cause the same issue. I'm bringing this to the rest of the team and we'll see if we can debug. Will keep you updated! Thanks 😊

Hi @jacobmclocklin , we've looked into this behavior with private Google Sheets, and it seems like the issue might be with a recent update made to the 1Password Chrome extension :) The issue is described here.

If you have the 1Password Chrome extension installed on your browser, could you please try this fix and see if it helps with the Google Auth issue ?

Please let us know if you do not have the extension or if the issue persists even after the fix.
Thanks!

Wow! That is it! Just a reminder for myself that I should have tested with no extensions enabled. Apologies for the false issue, and I'm glad that it is nothing to fix in this repo. I do hope that the extension owners can resolve this issue for others, so that we don't have to ask every user to change this setting or change their browser.

Thank you!

My organization uses 1pass and I ran into this issue as well. Incognito mode with no extensions did not help for some reason, but changing the 1pass setting as described in the posted fix settled my issue.

Just wanted to say thanks for solving this already! 👍