Still Maintained?
CodingAnarchy opened this issue · comments
Is the repository still maintained, or should we use the shoulda-matchers and shoulda-context directly? Those two seem to be updated periodically, but this is not.
@CodingAnarchy good question, I posted directly to thoughtbot on Twitter maybe a month ago about this and got no response as well. Guess I'll shoot in a PR myself as we ran into a pain point with this on a Rails 5.2.0 upgrade.
We had to roll back to 3.5 as 3.6 stopped playing nicely with shoulda-matchers.
We started getting "undefined method `validate_presence_of' for #<RSpec::" errors all over the place. That and every other shoulda-matcher method. validate-inclusion-of, belong_to, etc.
To answer the original question: Yes in the sense that someone is reading and triaging issues, No in the sense that I often don't make much progress on doing those given time constraints.
@iamwhil I'd suggest opening a new issue about that. It's possible that you're seeing known issues w/shoulda-matchers, as I know there's a few there.
I'm going to close this otherwise.
I think this is a valid question. There are new features in shoulda_matchers that I am not getting by using this gem.
@jasonperrone Hey! I just pushed up a bunch of fixes and released shoulda 4.0.0.rc1, which should allow you to make use of shoulda-matchers 4.x, as well as shoulda-context 2.0.0.rc2. Can you try it out and see if it works for you?
@mcmire thanks for that. I am a little confused though. So, I see that you pushed the changes to the main master branch, which is good. My Gemfile does not have shoulda locked to any particular version, so shouldn't "bundle update shoulda" have picked it up? It didn't, it's still seeing the latest version as 3.6.0 which is also what README.md says. I am sure I am doing something wrong, so please forgive me :)
NVM, this worked
gem 'shoulda', '~> 4.x'
I'll let you know how my tests go. Thanks again.
My solution above is not working anymore. What happened?
Had to do this:
gem 'shoulda', git: 'https://github.com/thoughtbot/shoulda.git', branch: :master
Honestly wish I didn't have to do that.
I'm not sure how it worked before, but Bundler doesn't usually pick up pre-releases by default.