thoughtbot / guides

A guide for programming in style.

Home Page:https://thoughtbot.com/playbook

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update how-to guide on feature-testing a Rails app’s Javascript?

tysongach opened this issue · comments

We have a guide on how to feature-test a Rails app’s JavaScript that suggests using capybara-webkit. We also have a blog post on how to swap capybara-webkit for Chromedriver and Suspenders (our Rails template) uses Chromedriver (see thoughtbot/suspenders@cf78134).

Should we update this guide? Should it be removed if it’s no longer providing value? Something else?

I think suspenders should be the source of truth for how to set up specs

If we keep the spec as an example, we should convert it into a system spec instead of a feature spec. I would also want us to give some indication of where create and sign_in_as are coming from.

I am in favor of either removing this section or replacing it with a few links (to suspenders, to the rspec-rails docs, etc.)

Maybe we remove this ‘how-to’ and add some details to our ‘Best Practices’ under the Rails and/or Testing heading(s) about using system tests?