Giters

thorvg / thorvg

Thor Vector Graphics is a lightweight portable library used for drawing vector-based scenes and animations including SVG and Lottie. It can be freely utilized across various software platforms and applications to visualize graphical contents.

Home Page:https://www.thorvg.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect arguments for 'result' Function in tvgLottieExpressions

theashraf opened this issue · comments

commented

Getting the following error when building ThorVG v0.13.4 in dotlottie-rs:

thorvg/src/loaders/lottie/tvgLottieProperty.h:590:23: error: no matching member function for call to 'result'
            if (exps->result<LottiePathSet>(frameNo, cmds, pts, transform, roundness, exp)) return true;
                ~~~~~~^~~~~~~~~~~~~~~~~~~~~
../../../../modules/thorvg/src/loaders/lottie/tvgLottieExpressions.h:157:38: note: candidate function template not viable: requires 5 arguments, but 6 were provided
    template<typename Property> bool result(TVG_UNUSED float, TVG_UNUSED Array<PathCommand>&, TVG_UNUSED Array<Point>&, TVG_UNUSED Matrix* transform, TVG_UNUSED LottieExpression*) { return false; }
                                     ^
../../../../modules/thorvg/src/loaders/lottie/tvgLottieExpressions.h:153:56: note: candidate function template not viable: requires 3 arguments, but 6 were provided
    template<typename Property, typename NumType> bool result(TVG_UNUSED float, TVG_UNUSED NumType&, TVG_UNUSED LottieExpression*) { return false; }
                                                       ^
../../../../modules/thorvg/src/loaders/lottie/tvgLottieExpressions.h:154:38: note: candidate function template not viable: requires 3 arguments, but 6 were provided
    template<typename Property> bool result(TVG_UNUSED float, TVG_UNUSED Point&, LottieExpression*) { return false; }
                                     ^
../../../../modules/thorvg/src/loaders/lottie/tvgLottieExpressions.h:155:38: note: candidate function template not viable: requires 3 arguments, but 6 were provided
    template<typename Property> bool result(TVG_UNUSED float, TVG_UNUSED RGB24&, TVG_UNUSED LottieExpression*) { return false; }
                                     ^
../../../../modules/thorvg/src/loaders/lottie/tvgLottieExpressions.h:156:38: note: candidate function template not viable: requires 3 arguments, but 6 were provided
    template<typename Property> bool result(TVG_UNUSED float, TVG_UNUSED Fill*, TVG_UNUSED LottieExpression*) { return false; }

build command:

meson setup --prefix=/ --backend=ninja -Dloaders="lottie, png, jpg, webp" -Ddefault_library=static -Dbindings=capi -Dlog=false -Dstatic=false -Dsavers= -Dextra=  "deps/modules/thorvg" "deps/build/local-arch/thorvg/build"
commented

@mgrudzinska is this #2291 related?

commented

@theashraf Please check the fix #2291. You can quickly apply it in your local build for a temporary solution. Sorry for the inconvenience.

commented

@hermet I can update my local build with it, but it would be still an issue on our CI, any plans to patch this update to v0.13.4?

commented

@theashraf 0.13.4 has been released already. The fix will be in v0.13.5 this week. Is it ok?

commented

@hermet Can we update the 0.13.x branch with this fix ?

commented

@theashraf updated. please pull again.