thomasp85 / ggraph

Grammar of Graph Graphics

Home Page:https://ggraph.data-imaginist.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Revdep check failure with upcoming ggplot2 3.5.0

teunbrand opened this issue · comments

Hi Thomas,

As you know, a new version of ggplot2 is coming up.
{ggraph} was in the list of packages with revdep failures.
While investigating, I've isolated the cause to the following lines:

draw_key = function(data, params, size) {
rectGrob(gp = gpar(
col = NA, fill = alpha(data),
lty = 0
))
},

Where data is not (anymore) a vector but a <data.frame>.
Should be fixable by using:

fill = alpha(data$edge_fill %||% data$fill %||% "darkgrey")

Cheers