Add yaw argument to CameraGeometry constructor
thomasfermi opened this issue · comments
camera_geometry.py from the lane detection chapter should be improved such that the CameraGeometry constructor also accepts yaw as an argument (not only pitch). The corresponding exercise also needs to be adapted.
This is needed for the CameraCalibration chapter.
This method will be useful. Order of rotation needs to be considered (see #19 )
Commit aa41081 solves this.
Now the full rotation matrix with yaw,pitch,roll is being used. It is also given in the exercise so that the student does not need to implement it. Problem: Within the lane detection chapter this yaw,pitch,roll matrix business is never explained. So a student reading this code might get confused.
This should be solved within this issue now.
Added explanation to lane detection chapter. This closes the issue