[Improvement] Adding Instrumented Test for UI

Question

[Improvement] Adding Instrumented Test for UI

hoangnguyen92dn opened this issue 2 years ago · comments

Issue

As you already added UnitTest for some classes (SurveyRepositoryImplTest, AuthenticationRepositoryImplTest, and you also mentioned adding ViewModel + UseCase test classes), there is no Instrumented test case for the UI part to test the behavior of user actions

Expected

I would suggest adding some Instrumented Tests for screens to verify the app behavior on user actions.

(Bruce) Thien Nguyen · Answer 1 · Thu Apr 28 2022 02:11:12 GMT+0800 (China Standard Time)

Instrumentation test has been added in PR #24

Huey · Answer 2 · Thu Apr 28 2022 17:45:29 GMT+0800 (China Standard Time)

@thiennguyen0196 When I execute the test on my device all the tests failed. Or could you please show me the test passed proof on your local?

(Bruce) Thien Nguyen · Answer 3 · Fri Apr 29 2022 11:31:33 GMT+0800 (China Standard Time)

@hoangnguyen92dn

Hmm 🤔 It seemed odd to me because when I run the android test in my emulator (freshly start with prodDebug build variants), every test case is executed successfully.
Here is my record screen:

Screen.Recording.2022-04-29.at.10.23.48.AM.mov

Huey · Answer 4 · Fri Apr 29 2022 12:21:01 GMT+0800 (China Standard Time)

@thiennguyen0196 I tried on the emulator but there are some tests that failed once logged in 😅

Huey · Answer 5 · Fri Apr 29 2022 12:25:31 GMT+0800 (China Standard Time)

@thiennguyen0196 Anw, thanks for the update. We will review and conclude based on your test cases 💪