[Improvement] Extract email validation for common usage

[Huey]

Issue

There is the same logic to validate an email in ForgotViewModel and LoginViewModel so I'd suggest extracting this to a function for common usage.

survey/app/src/main/java/com/thiennguyen/survey/feature/forgot/ForgotViewModel.kt

Lines 24 to 28 in 2f0fc36

 fun resetPassword(email: String) { 
     when { 
         email.isBlank() || !Patterns.EMAIL_ADDRESS.matcher(email).matches() -> { 
             onResetPasswordChange.postValue(ResetPasswordState.EmailInvalid) 
         } 

survey/app/src/main/java/com/thiennguyen/survey/feature/login/LoginViewModel.kt

Lines 25 to 29 in 2f0fc36

 fun submitLogin(email: String, password: String) { 
     when { 
         email.isBlank() || !Patterns.EMAIL_ADDRESS.matcher(email).matches() -> { 
             onLoginStateChanged.postValue(LoginState.EmailInvalid) 
         } 

Expected

The email validation function will be created and invoked in the ViewModel classes.

[(Bruce) Thien Nguyen]

This is fixed in PR #22

[Huey]

@thiennguyen0196 For this issue, I am not sure about your idea by using Inline class rather than extension 🤔 Can you please explain in detail why you would go with the current approach instead?

[(Bruce) Thien Nguyen]

@hoangnguyen92dn
Indeed using extension was my first thought to extract the common usage function. However, in this case, I also want to distinguish between email text and password text so they cannot be passed wrongly in the arguments of viewModel.submitLogin() function. For example, if they are still string type, there is a chance that we could pass password text for email field and vice versa.

To sum up, I use inline class to have more strict usage in passing arguments with viewModel.submitLogin() function 😄

[Huey]

Got your idea now. Thanks for your explanation 👍