thewhitetulip / build-app-with-python-antitextbook

Aims to teach Python3 by example

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Feedback

thewhitetulip opened this issue · comments

Give your feedback here!

Feedback from @jaivasani on #33

I'm not sure if there is a dedicated feedback section. So I am writing my feedback here.

The book and the videos were really helpful in learning python. (Thanks for that!)

The only place I had trouble was in executing the first python program.

  1. I am using windows and to run python program I had to type py filename.py instead of python filename.py. It would would be helpful if you can mention about py in the description somewhere.

  2. It took me a while to figure out how to install iPython package using the pip. Then it took me a while to figure out what pip command to use to install the package and if it was actually the correct command to install. A small step-by-step instructions on what commands to type in command prompt would be really helpful for someone who is new to command line.

  3. You might want to check your 10-task.md file. In the remove() function

## snippet
elif command == "remove":
	try:
		file = open("tasks.txt", "r")
	except IOError as e:
		print(str(e))
		sys.exit(1)
	
	tasks = file.readlines()
	tasks = [task.strip() for task in tasks]
	task_id = args[2]
	del tasks[int(task_id)]

Here we are deleting the task from the tasks list. But after we delete the task, we are not updating the text file. Hence, when we run the list command, the list command still shows all the tasks including the one which we had previously deleted from the list.
It would be nice if you can add a code to write to file before the program ends or before the remove function ends.

Thanks,
Jai