About the README
sayakpaul opened this issue · comments
@vasudevgupta7 the README looks superb now!
I have a few suggestions that might make it even better:
- I see that you have included instructions on how to load the model from Hugging Face Hub which is great. Do you think we could add something similar for TF Hub too? Maybe a note to guide the readers that they can pretty do the similar thing in TensorFlow by doing [...]?
- While we are on the topic of ASR, do you think it might be good to mention a few other projects that are doing exceptional work in the area and even compare performances qualitatively? I understand this might be difficult for you to accommodate right away. So, feel free to either have this under future works or you can completely discard the choice (I won't mind).
- I see that you have included instructions on how to load the model from Hugging Face Hub which is great. Do you think we could add something similar for TF Hub too? Maybe a note to guide the readers that they can pretty do the similar thing in TensorFlow by doing [...]?
Sure, will do that.
- While we are on the topic of ASR, do you think it might be good to mention a few other projects that are doing exceptional work in the area and even compare performances qualitatively? I understand this might be difficult for you to accommodate right away. So, feel free to either have this under future works or you can completely discard the choice (I won't mind).
Yes, I can do that on 22 night or on 23 Aug. Since deadline is 23rd, that should be fine right?
Absolutely. Don't sweat it.
Hey @sayakpaul, I couldn't work on it (sorry for that). I will work on this issue in a couple of days. So shifting this to post-GSoC plan.
Don't worry about it. But will it be difficult for you to take care of the first point? I understand if it's the case.
I will work on 1st point by tonight.
@vasudevgupta7 could you also update the README with your tutorial?
https://www.tensorflow.org/hub/tutorials/wav2vec2_saved_model_finetuning