[Bug] Dot is too big in landscape mode
Glitchy-Tozier opened this issue · comments
Pictures are pretty self-explanatory, I think:
actually the dot is not made to fit inbetween the 5cent lines, but as far as I recall its dependent on the text size. So its size depends also on your phone settings. I would prefer not to couple the size to the 5cent lines, since coupling stuff also makes work harder in future (one extra issue you have to make sure not to break :-). E.g. what if the 5c lines are increased to a 10c limit since this is really good enough? Should the dot grow? What if we make the limit smaller? Is the dot now becoming to small?
But I understand that on your screen it looks like it should fit inbetween since its size almost fits ...
I don't think this is my phone's fault.
In normal, vertical mode the dot fits perfectly.
It is only in horizontal mode that it is too large (see original screenshots), and I doubt that my phone changes font-sizes when its being rotated.
no, its not the font size that changes, its the distance of the 5c line that changes. Meaning that depending on plot size the 5c lines are further apart of closer ... Since I don't scale the dot with the plot size it somtimes fits inbetween the lines and sometimes not. For most plots this is the expected behavior: Symbols and line widths should not be dependent on the size since otherwise the will either become too small or weirdly thick.
But the purpose of the dot is to fit right between those lines, isn't it?
no, the purpose of the dot is to mark the head of the line. It is not connected to the 5c lines. That it fits in your portrait mode is indeed a coincidence. Phones with other screen/font sizes will yield different results.
Interesting, i see.
Personally, i think it would look great if the dot always filled out the two lines perfectly, but if you don't like that change, we can close this issue now :)
I understand, that such this detail in theory would be nice. But since it really depend on many factors, when it is helpful and when not (as said, phone format is a factor but there are also others like the ranges of the plot, the 5c-tolerance, the plot layout, ...), I think the most consistent solution is to have it independent. So I will close this issue. Still, thanks a lot for the suggestions.