thetanz / OpenFeature-al

OpenFeature for AL transforms Application Areas into feature toggles.

https://theta.co.nz

Deleting a feature flag does not disable functionality

spookymattress opened this issue 3 years ago · comments

SpookyMattress commented 3 years ago

I have created a feature flag called "MyFeat" and enabled it. Works fine!

When I delete the feature flag, the functionality is still active. Shouldn't it be disabled? Or what is the intended behaviour?

Vlad Leonov commented 3 years ago

@spookymattress, looks like that app recalculates a flag only if you manually delete a condition:
https://github.com/thetanz/featureflags-al/blob/5b34891c5f2e88e5bdf20633efe10ea5b1d2be3b/MAIN/src/table/FeatureFlag.Table.al#L78
https://github.com/thetanz/featureflags-al/blob/5b34891c5f2e88e5bdf20633efe10ea5b1d2be3b/MAIN/src/codeunit/FeatureFlagMgt.Codeunit.al#L139
Thank you for this feedback. Will work out a fix for this.

Vlad Leonov commented 3 years ago

@spookymattress, could you please validate a latest version, so will close as confirmed.