thephpleague / flysystem

Abstraction for local and remote filesystems

Home Page:https://flysystem.thephpleague.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

AdapterDefinitionFactory::createDefinition() breaking change

stefan1144 opened this issue · comments

Bug report

Q A
Flysystem Version 3.18.0

Summary

The BC was introduced in this version in the League\FlysystemBundle\Adapter\AdapterDefinitionFactory , createDefinition method.
?string $defaultVisibilityForDirectories has been added as the last argument, however there is no value set by default (null, per example).

Although class is marked as “internal” it is quite useful, we are using it, and adding third optional parameter could have default value.
Thanks.

Hi @stefan1144, can you raise this issue with the https://github.com/thephpleague/flysystem-bundle repository? That way the maintainers see it.