Parameter missing and a suggestion

Question

woxiangfy opened this issue 5 years ago · comments

Container.php file get method

line 162 change to

        $arrayOf = $this->definitions->resolveTagged($id,$new);

a suggestion:

add function

hasTag
getTag

getTag(Array returned )different from get。

Viktor Szépe · Answer 1 · Wed Apr 08 2020 12:06:35 GMT+0800 (China Standard Time)

@philipobenito Should this be fixed?

May I send a PR?

Phil Bennett · Answer 2 · Mon May 18 2020 16:21:58 GMT+0800 (China Standard Time)

Fixed in 3.3.1

Viktor Szépe · Answer 3 · Mon May 18 2020 16:46:59 GMT+0800 (China Standard Time)

@philipobenito Could you elaborate in which commit?

Phil Bennett · Answer 4 · Mon May 18 2020 16:49:59 GMT+0800 (China Standard Time)

There is only one commit in the release 93238f7

Viktor Szépe · Answer 5 · Mon May 18 2020 16:56:42 GMT+0800 (China Standard Time)

Thank you.

It is missing from master :(

Phil Bennett · Answer 6 · Mon May 18 2020 17:02:16 GMT+0800 (China Standard Time)

Yeah there's a mismatch on master currently, 3.x pointer is on 3.x branch now ready for 4.x release