Pass the container to factory closures (callables) by default

[Daniel Opitz]

For performance reason I use a lot of factory closures/anonymous functions to build objects.

Very often the container object is needed. Here is a generic example:

$container = new League\Container\Container;

$container = new Container();

$container->add(Foo:class, static function(ContainerInterface $container) {
    $bar = $container->get(Bar::class)
    return new Foo($bar);
})->addArgument($container);

You see, I always have to call addArgument to pass the container instance. My question / feature request is: Would it be possible to pass the container instance by default if no extra argument is defined via addArgument?

This is also the default parameter-list for PHP-DI factories and it would be great to have this as default too.

Ideally a minimal closures/anonymous function could be defined in this way:

use Psr\Container\ContainerInterface;

$container->share(ContainerInterface::class, static function (ContainerInterface $container) {
    return $container;
})->addArgument($container);

// All other callables can be added without calling addArgument
$container->add(Foo:class, static function(ContainerInterface $container) {
    $bar = $container->get(Bar::class)
    return new Foo($bar);
});

[Daniel Opitz]

Is there no interest? If not, I will close this PR.

[Phil Bennett]

Hi, I've been on holiday, just catching up but this is unlikely to go in, when I have more time I'll explain why and show you an easy way to achieve the same thing.

…

-------- Original Message --------

On 2 Oct 2019, 12:34, Daniel Opitz wrote: Is there no interest? If not, I will close this PR. — You are receiving this because you are subscribed to this thread. Reply to this email directly, [view it on GitHub](#183?email_source=notifications&email_token=AAP3E2N5QZ4EMK4KAJN3O2TQMSBKZA5CNFSM4IULFSS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAEN2DI#issuecomment-537451789), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AAP3E2LGTUWXIB2VMWLNKVDQMSBKZANCNFSM4IULFSSQ).

[Daniel Opitz]

Hi @philipobenito Where can I find more information about this topic? Do you have a small example?