Giters

thephpleague / color-extractor

Extract colors from an image like a human would do.

Home Page:thephpleague.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

BadMethodException thrown for use of undefined method [package] in Laravel 5

ajaaibu opened this issue · comments

commented

Issue:
In laravel 5 when the ServiceProvider is loaded it throws BadMethodCallException for use of undefined method [package].

Fix:
Commenting out the boot() section of the ServiceProvider works fine.

commented

I don't know anything about Laravel. Ping @toin0u, @GrahamCampbell

commented

@ajaaibu The service provider in the library is only for Laravel 4. Do you mind to make a pull request? :)

commented

@toin0u sorry i forgot to make the pull request after adding a fix on my fork, just now made the request :)

commented

+1 (subbed)

commented

@moltar there is a merge request here: #28 :)

commented

👎 for merging #28 it makes no sense to duplicate the service provider. #30 will fix this issue. There is literally no point in us even calling the package method. All that does is tell laravel where to look for the config and views, but we don't have any, and we missconfigured that package method anyway even if we did...