/stream/items/ids limit does not support n > 1000
noinnion opened this issue · comments
@krasnoukhov It seems that /stream/items/ids limit does not support more than 1000. It would destroy 2-way sync feature.
Hey @noinnion, thanks for reporting. What do you mean by 2-way sync feature? And what if user has more than 1000 (all or even unread) items?
in gReader we use /stream/items/ids to synchronize unread items from server to client. i.e. items read on TheOldReader server will be synced back to gReader. If the limit is only 1000 items that are outside these 1000 items will no be recognize. gReader uses incremental synchronization so that only new items are downloaded.
Hope you can increase the limit to 10000 as before.
Ok, I see. So, if user has more than 10000 unread items gReader won't sync them all? (Assuming the limit is 10000)
10000 should be enough. Everything larger than 10000 could be ignored.
Hope you can fix it as soon as possible. The problem right now is that it breaks gReader functionalities.
I'll try to figure how we can fix this asap. In the meantime, is there any reason why gReader doesn't use continuation for any cases when not all data is fetched? I'm pretty sure there are people with 10000 or more items.
we use continuation to get more than 1k items. but more than 10k is too much for a reader. (/stream/items/ids does not support continuation) We also use nt/ot to optimize synchronization.
if ppl have more than 10k items in their inbox that means they are not using it for a while. All these items outside these 10k are not relevant anymore. Also using more than 10000 would slow down the app in term of performance.
@krasnoukhov I just see that there is a continuation in the response.
It could solve the issue but using it is not very convenient. Increasing limit to 10k is a lot of better.
Thanks
Ok, limit is 10000 for ids now, please see related note in readme.
great, thank you for the quick fix