The JavaScript Way Translation in Persian
najmiehsa opened this issue · comments
Hi,
@bpesquet I want to contribute and start the Persian translation of this book. Can I do that? Please let me know
Thank you.
Hi,
Sorry for answering so late, I just came back from some holidays.
It's a great idea! I'll set up the repo and give you write access ASAP.
Thanks in advance.
This is great. Thank you
@bpesquet Please let me know if I can contribute to the translation of The JavaScript Way book, Thank you.
I close this. Thank you for the reply.
Hi,
Sorry for the long delay. I just created the persian repo and invited you into the translation team.
Feel free to ask any question, I'll promise to answer them more quickly ;)
Thanks in advance!
Thank you so much. I start the Persian translation right away. This is awesome!
@bpesquet I translated three sections so far. this is the Readme
https://github.com/najmiehsa/thejsway_per/blob/main/README.md
there are two sentences missing here and those are:
As a DRM-free Kindle or paperback book on Amazon.
As an interactive online course on Educative.
I am trying to figure out the markdown for this since the Persian language is from right to left and needs some configurations.
I am unsure why I can not submit a PR to the Persian repo. Something else I am trying to figure out is the ESlint for the Persian repo.
Hi,
Rather than forking it, you should be able to clone the persian repo then push to it directly.
Let me know if you still have difficulties.
Thanks in advance for your work!
@bpesquet hi,
Thanks for the tip.
I didn't know that changing my fork would cause many commits to this PR
I re-adjusted it in the second one
@bpesquet I merge the PRs to see the progress. I modify any changes that are required based on them.
Please tell me If I need to follow a review and then merge workflow.
Just an update: I am facing an slow net connection and I can not submit PRs here.
I''ve done couple more chapters and I'll soon update the Persian Repo.
@bpesquet I am sorry please remove the Persian repository.
I want to delete my GitHub account.
Regards.